New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fancybox to 3.5.1 #6120

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@sshcli
Member

sshcli commented Sep 30, 2018

Summary of Changes

Improvements
New option preventCaptionOverlap (enabled by default for desktop only) prevents caption from overlapping the content;
HTML5 video now uses thumbnail image as poster;
Redesigned caption - centered, without top border and does not hide when idling (and preventCaptionOverlap is enabled);
It is now easier to set content height in % (especially for iframes), there is no need to adjust bottom margin and max-height (caused by this - bugzilla.mozilla.org/show_bug.cgi?id=748518), because bottom margin is applied automatically using JS)

Fixes
Fixed thumbnail visibility detection (now works better with sliders);
Fixed share modal not closing when clicking outside content area;
Fixed iframe support for iOS
Fixed missing HTML5 video poster

@810 810 merged commit 6057c99 into Kunena:K5.1 Oct 9, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment