Remove hard coding from bbcode editor #6123
Merged
Conversation
|
Done |
Only one question: Why is added this one string "Text::script('COM_KUNENA_EDITOR_UNORDERED_LIST');"? We have already the translated string "Text::script('COM_KUNENA_EDITOR_ULIST'); for the same option. The string "Text::script('COM_KUNENA_EDITOR_UNORDERED_LIST');" is unneeded, I think. |
Didn't notice. Has been removed now |
Not your mistake. I've noticed today that this string is unneeded. It would be a orphaned string without function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Pull Request for Issue #6122