New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coding from bbcode editor #6123

Merged
merged 3 commits into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@sshcli
Member

sshcli commented Oct 5, 2018

Pull Request for Issue #6122

@810

This comment has been minimized.

Member

810 commented Oct 5, 2018

  1. the js is created by \libraries\kunena\bbcode\editor.php
  2. check also crypsisb3
@sshcli

This comment has been minimized.

Member

sshcli commented Oct 5, 2018

check also crypsisb3

Done

@rich20

This comment has been minimized.

Member

rich20 commented Oct 5, 2018

  • Success

Only one question: Why is added this one string "Text::script('COM_KUNENA_EDITOR_UNORDERED_LIST');"? We have already the translated string "Text::script('COM_KUNENA_EDITOR_ULIST'); for the same option. The string "Text::script('COM_KUNENA_EDITOR_UNORDERED_LIST');" is unneeded, I think.
https://github.com/Kunena/Kunena-Forum/blob/K5.1/src/components/com_kunena/template/crypsis/layouts/topic/edit/default.php#L35

@sshcli

This comment has been minimized.

Member

sshcli commented Oct 5, 2018

Why is added this one string "Text::script('COM_KUNENA_EDITOR_UNORDERED_LIST');"?

Didn't notice. Has been removed now

@rich20

This comment has been minimized.

Member

rich20 commented Oct 5, 2018

Didn't notice.

Not your mistake. I've noticed today that this string is unneeded. It would be a orphaned string without function.

@810 810 merged commit 0718952 into Kunena:K5.1 Oct 9, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment