Fix invalid HTML in Twitter widget #6209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # N/A
When using Kunena discuss on my websites, I noticed that when there was a discussion, the layout of the template was 'corrupted' (sidebar showing up below kunena discuss content instead of as sidebar).
I found that I could reproduce this issue when there was an embedden tweet in the displayed dicussion.
As it turned out, the widget that renders the tweet misses a closing div, rendering the HTML invalid. I have a plugin that do a complete DOM saveHTML on the page before it is displayed. This 'fixes' broken HTML, but in this case the fix was not good as it corrupted the page.
Fixing the twitter widget layout solved the issue :)
Summary of Changes
Fixing layout of both crypsis and crypsysb3 bbcode twitter widget layout
Testing Instructions
create adiscussion with a link to a tweet in it. The discussion should render as before (but now passing HTML validation)