Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid HTML in Twitter widget #6209

Merged
merged 1 commit into from Feb 26, 2019

Conversation

Projects
None yet
2 participants
@Ruud68
Copy link
Contributor

Ruud68 commented Feb 22, 2019

Pull Request for Issue # N/A

When using Kunena discuss on my websites, I noticed that when there was a discussion, the layout of the template was 'corrupted' (sidebar showing up below kunena discuss content instead of as sidebar).
I found that I could reproduce this issue when there was an embedden tweet in the displayed dicussion.

As it turned out, the widget that renders the tweet misses a closing div, rendering the HTML invalid. I have a plugin that do a complete DOM saveHTML on the page before it is displayed. This 'fixes' broken HTML, but in this case the fix was not good as it corrupted the page.

Fixing the twitter widget layout solved the issue :)

Summary of Changes

Fixing layout of both crypsis and crypsysb3 bbcode twitter widget layout

Testing Instructions

create adiscussion with a link to a tweet in it. The discussion should render as before (but now passing HTML validation)

@810 810 merged commit 09e439f into Kunena:K5.1 Feb 26, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@Ruud68 Ruud68 deleted the Ruud68:FixTwitterWidget branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.