Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP error: 'invalid argument for foreach() in bbcode.php line 409" #6633 #6637

Merged
merged 1 commit into from Dec 21, 2019

Conversation

xillibit
Copy link
Member

@xillibit xillibit commented Dec 21, 2019

Pull Request for Issue #6333 .

Summary of Changes

Testing Instructions

@xillibit xillibit added this to the 5.1.16 milestone Dec 21, 2019
@@ -400,65 +400,68 @@ public function Internal_AutoDetectURLs($string)
(?:
\((?:[^\s()<>]+|(\(?:[^\s()<>]+\)))*\)
|
[^\s`!()\[\]{};:\'"\.,<>?«»“”‘’]
[^\s`!()\[\]{};:\'"\.,<>?������]
Copy link
Member

@810 810 Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this back

$invalid = preg_match('#[^\s`!()\[\]{};\'"\.,<>?«»“”‘’]$#u', $search[$index - 1]);
$invalid |= !$this->IsValidURL($url, true);
// Never start URL from the middle of text (except for punctuation).
$invalid = preg_match('#[^\s`!()\[\]{};\'"\.,<>?������]$#u', $search[$index - 1]);
Copy link
Member

@810 810 Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@810 810 merged commit 7c02478 into Kunena:K5.1 Dec 21, 2019
3 checks passed
@xillibit xillibit deleted the K5.1_bugs1 branch Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants