Mail subscription sending delay to after response #6648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--HG-- branch : mail-dpc
…p request have answered. * subscriptions sending now starts at event onAfterRespond. So, responding to user request have sent as faster as can, and after that starts mailing for a looong time. --HG-- branch : mail-dpc
…tus of subscription mailing --HG-- branch : mail-dpc
…ena update? * session close lazy - when no subscriptions are mailed, do not force session close. sent http answer ordinary way --HG-- branch : mail-dpc
--HG-- branch : mail-dpc
alexrayne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: if some topic have many subscriptions, mailing them take much time - about 1sec/letter. For 70 subscriptions mailng accupy more then minute. Users don`t wait this time, they just go away from forum.
Changes:
here provided delay of subscription mailing after http request responded. Therefore, subscription placed in event onAfterRespond. before mail, it flushes and close http session -thus response go to browser, and after that starts to mail all the time it need.