-
-
Notifications
You must be signed in to change notification settings - Fork 808
[K5.1] Attachment reference and content deleted on remove/all #5716 #6715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If you insert images with the button "insert all" in messages and you remove one of this image with the button "Remove file", you get in the message field the word false. When you save then remains only this word in the message and from the rest of the images remain only thumbnails. |
This pr is stale because it has been open 30 days with no activity. We are looking at it how we can include your code changes. |
@rich20 : can-you try now ? |
Delete via backend or frontend file manager is for me ok now but only for attachments which have been inserted one by one. I don't understand why there is a difference on delete if you insert the attachments one by one or have been added with the button "Insert all". These issues exists only with attachments which are inserted with the button Insert AllEdit message
Frontend attachment manager
Backend file manager
|
Because it's two diffrents functions :remove with insert all and remove all files |
08e6d93
to
eccc8a3
Compare
That's is something that @jelle has added but i don't understand exactly the purpose |
when the image is inline, then the image isn't showed on the attachment under the message. |
Please add insert all, on edit message. Also when insert 3 from 6 images, all images are showed on the thumbnail bellow the message. |
I will look at it |
ok, thats looking better, next issue: When insert all, skip files that already in the message. |
The button "Remove All" removes itself if you click on it. It's indifference with which button the attachments have been inserted.
|
I will fix that in another PR |
Pull Request for Issue #5716 .
Summary of Changes
Testing Instructions