Skip to content

[K5.1] Attachment reference and content deleted on remove/all #5716 #6715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 13, 2020

Conversation

xillibit
Copy link
Member

@xillibit xillibit commented Jan 8, 2020

Pull Request for Issue #5716 .

Summary of Changes

Testing Instructions

@xillibit xillibit added this to the 5.1.16 milestone Jan 8, 2020
@rich20
Copy link
Member

rich20 commented Jan 9, 2020

If you insert images with the button "insert all" in messages and you remove one of this image with the button "Remove file", you get in the message field the word false. When you save then remains only this word in the message and from the rest of the images remain only thumbnails.

@github-actions
Copy link

This pr is stale because it has been open 30 days with no activity. We are looking at it how we can include your code changes.

@810 810 modified the milestones: 5.1.16, 5.1.17 Mar 21, 2020
@xillibit
Copy link
Member Author

@rich20 : can-you try now ?

@rich20
Copy link
Member

rich20 commented Apr 11, 2020

Delete via backend or frontend file manager is for me ok now but only for attachments which have been inserted one by one.

I don't understand why there is a difference on delete if you insert the attachments one by one or have been added with the button "Insert all".
If you use the button "Insert all" remain all codes, whether indifferent text is in the message or not.

These issues exists only with attachments which are inserted with the button Insert All

Edit message

  • Attachments which have been inserted with the button "Insert all" all will be removed from the text field if you want only remove a single attachment. It adds the word "false" in the text field instead.

Frontend attachment manager

  • Attachments which have been inserted with the button "Insert all" will be removed but all codes remain in the message

Backend file manager

  • Attachments which have been inserted with the button "Insert all" will be removed but all codes remain in the message

@xillibit
Copy link
Member Author

I don't understand why there is a difference on delete if you insert the attachments one by one or have been added with the button "Insert all".

Because it's two diffrents functions :remove with insert all and remove all files

@rich20
Copy link
Member

rich20 commented Apr 11, 2020

There is also the option "Remove attachment from the list". But this option is only available, when the attachments would have been inserted one by one.
You see it on the image, I've added the first attachment with the button Insert All and here lacks this option.
Bildschirmfoto von 2020-04-11 19-59-32

@xillibit xillibit force-pushed the K5.1_bugs10 branch 2 times, most recently from 08e6d93 to eccc8a3 Compare April 12, 2020 20:49
@xillibit
Copy link
Member Author

There is also the option "Remove attachment from the list". But this option is only available, when the attachments would have been inserted one by one.
You see it on the image, I've added the first attachment with the button Insert All and here lacks this option.

That's is something that @jelle has added but i don't understand exactly the purpose

@810
Copy link
Member

810 commented Apr 12, 2020

when the image is inline, then the image isn't showed on the attachment under the message.
Before it showed in the message and under the message on the attachment list.

@810
Copy link
Member

810 commented Apr 13, 2020

Please add insert all, on edit message.

Also when insert 3 from 6 images, all images are showed on the thumbnail bellow the message.

@xillibit
Copy link
Member Author

xillibit commented Apr 13, 2020

Please add insert all, on edit message.

Also when insert 3 from 6 images, all images are showed on the thumbnail bellow the message.

I will look at it

@810
Copy link
Member

810 commented Apr 13, 2020

ok, thats looking better, next issue: When insert all, skip files that already in the message.

@810 810 merged commit 37e04ef into Kunena:K5.1 Apr 13, 2020
@rich20
Copy link
Member

rich20 commented Apr 13, 2020

The button "Remove All" removes itself if you click on it. It's indifference with which button the attachments have been inserted.
Reproduce it:

  1. Add on reply one or more attachments in the message
  2. Click on Remove All (it removes only the Remove All button the attachments remain)

@xillibit
Copy link
Member Author

ok, thats looking better, next issue: When insert all, skip files that already in the message.

The button "Remove All" removes itself if you click on it. It's indifference with which button the attachments have been inserted.
Reproduce it:

1. Add on reply one or more attachments in the message

2. Click on Remove All (it removes only the Remove All button the attachments remain)

I will fix that in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants