Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the ProhibitNoAbortFunction message #304

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@Carpetsmoker
Copy link
Contributor

Carpetsmoker commented Mar 11, 2019

The ProhibitNoAbortFunction checks for both the abort attribute and
whether the bang is used for the function command, but the error didn't
mention this.

This is quite confusing, and it took me a while to figure out why vint
was failing on two functions in my project. This should clarify it.

Fixes #232

Clarify the ProhibitNoAbortFunction message
The ProhibitNoAbortFunction checks for both the abort attribute and
whether the bang is used for the function command, but the error didn't
mention this.

This is quite confusing, and it took me a while to figure out why vint
was failing on two functions in my project. This should clarify it.

Fixes #232
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #304 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   70.68%   70.68%           
=======================================
  Files         133      133           
  Lines        7705     7705           
  Branches     1252     1252           
=======================================
  Hits         5446     5446           
  Misses       1930     1930           
  Partials      329      329
@blueyed

This comment has been minimized.

Copy link
Collaborator

blueyed commented Mar 11, 2019

Using function! is actually being discouraged now (for newer Vim versions): https://groups.google.com/d/msg/vim_dev/CkqcxQgntVg/JjYGnLP8BwAJ

#232 also mentions a bug with this (when using inside other functions IIRC).

But for now I think this is the best quick fix.

@blueyed blueyed merged commit 9c591c8 into Kuniwak:master Mar 11, 2019

3 checks passed

codecov/changes No unexpected coverage changes found.
Details
codecov/patch 100% of diff hit (target 70.68%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@blueyed

This comment has been minimized.

Copy link
Collaborator

blueyed commented Mar 11, 2019

Thanks!

@Carpetsmoker Carpetsmoker deleted the Carpetsmoker:abort-bang branch Mar 11, 2019

@Carpetsmoker

This comment has been minimized.

Copy link
Contributor Author

Carpetsmoker commented Mar 11, 2019

Using function! is actually being discouraged now (for newer Vim versions): https://groups.google.com/d/msg/vim_dev/CkqcxQgntVg/JjYGnLP8BwAJ

Nice! Unfortunately many people use very old Vim versions, so it'll take a few years before this can actually be used (thanks Debian!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.