New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeneratorBundle] Replace DialogHelper with QuestionHelper #304

Merged
merged 1 commit into from Jun 2, 2015

Conversation

Projects
None yet
2 participants
@arneruy
Copy link
Contributor

arneruy commented Apr 10, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #71, #88

This feature replaces all calls to DialogHelper with QuestionHelper in the GeneratorBundle since the DialogHelper is deprecated since Symfony 2.5 .

@roderik roderik added this to the 3.2.0 milestone Apr 10, 2015

@roderik

This comment has been minimized.

Copy link
Contributor

roderik commented Apr 10, 2015

@krispypen travis fails on symfony 2.3, if we want to follow, we need to up the minimal symfony version. Let's delay this for 3.2

@roderik

This comment has been minimized.

Copy link
Contributor

roderik commented Jun 2, 2015

@arneruy please rebase

arneruy

@arneruy arneruy force-pushed the arneruy:feature_88 branch from 254d7ee to 49c56f7 Jun 2, 2015

@arneruy

This comment has been minimized.

Copy link
Contributor

arneruy commented Jun 2, 2015

@roderik solved merge conflicts

roderik pushed a commit that referenced this pull request Jun 2, 2015

Roderik van der Veer
Merge pull request #304 from arneruy/feature_88
[GeneratorBundle] Replace DialogHelper with QuestionHelper

@roderik roderik merged commit 653b3d4 into Kunstmaan:master Jun 2, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment