New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeBundle] Don't BC break nodeTranslation introduced when we depreciated the service method #377

Merged
merged 1 commit into from Apr 27, 2015

Conversation

Projects
None yet
4 participants
@woutervandamme
Copy link
Contributor

woutervandamme commented Apr 27, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #376
@kimausloos

This comment has been minimized.

Copy link
Contributor

kimausloos commented Apr 27, 2015

@woutervandamme woutervandamme force-pushed the woutervandamme:bugfix/nodeTranslation branch from f8b12f0 to 0b2d52e Apr 27, 2015

@krispypen

This comment has been minimized.

Copy link
Member

krispypen commented Apr 27, 2015

indeed, not tested? :)

woutervandamme

@woutervandamme woutervandamme force-pushed the woutervandamme:bugfix/nodeTranslation branch from 0b2d52e to 9e1cead Apr 27, 2015

@kimausloos

This comment has been minimized.

Copy link
Contributor

kimausloos commented Apr 27, 2015

@krispypen 👍 for me now :)

@krispypen

This comment has been minimized.

Copy link
Member

krispypen commented Apr 27, 2015

@roderik also for me 👍

@roderik roderik changed the title fixed nodeTranslation bc break [NodeBundle] Don't BC break nodeTranslation introduced when we depreciated the service method Apr 27, 2015

@roderik roderik added this to the 3.1.1 milestone Apr 27, 2015

roderik pushed a commit that referenced this pull request Apr 27, 2015

Roderik van der Veer
Merge pull request #377 from woutervandamme/bugfix/nodeTranslation
[NodeBundle] Don't BC break nodeTranslation introduced when we depreciated the service method

@roderik roderik merged commit 92c97c9 into Kunstmaan:master Apr 27, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@woutervandamme woutervandamme deleted the woutervandamme:bugfix/nodeTranslation branch May 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment