New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeneratorBundle] Refactor pagepart media validation #406

Merged
merged 1 commit into from May 26, 2015

Conversation

Projects
None yet
3 participants
@arneruy
Copy link
Contributor

arneruy commented May 13, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

Adding validation for media objects in pageparts is no longer obligated. You no longer have to set minimum/maximum dimension values for images if you don't want to. Instead you can skip the validation part and add it later directly into the form files if you want to. This makes for a more userfriendly experience when generating pageparts.

screen shot 2015-05-13 at 11 09 06

arneruy
Make validation optional
code formatting

fix error minheight undefined
@roderik

This comment has been minimized.

Copy link
Contributor

roderik commented May 26, 2015

@krispypen 👍 (the failed test was a scrutinizer error when transmitting, not a test)

krispypen added a commit that referenced this pull request May 26, 2015

Merge pull request #406 from arneruy/issue_ppimage
[GeneratorBundle] Refactor pagepart media validation

@krispypen krispypen merged commit 92c789a into Kunstmaan:master May 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment