New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeSearchBundle] Refactored search to seperate service #465

Merged
merged 1 commit into from Jun 9, 2015

Conversation

Projects
None yet
3 participants
@woutervandamme
Copy link
Contributor

woutervandamme commented Jun 2, 2015

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets /
@@ -18,132 +18,22 @@
*/
class AbstractSearchPageController extends Controller{

This comment has been minimized.

@wimvds

wimvds Jun 2, 2015

Contributor

Apply Symfony2 coding guidelines please.

@wimvds

This comment has been minimized.

Copy link
Contributor

wimvds commented Jun 2, 2015

This looks like a breaking change, not a bugfix.

@woutervandamme woutervandamme force-pushed the woutervandamme:feature/search branch from 04e1371 to b22f584 Jun 2, 2015

@roderik

This comment has been minimized.

Copy link
Contributor

roderik commented Jun 6, 2015

@woutervandamme if this is a bc break, there should be something in the upgrade docs about it

woutervandamme
service
update upgrade.md

@woutervandamme woutervandamme force-pushed the woutervandamme:feature/search branch from b22f584 to bce909e Jun 8, 2015

roderik pushed a commit that referenced this pull request Jun 9, 2015

Roderik van der Veer
Merge pull request #465 from woutervandamme/feature/search
[NodeSearchBundle] Refactored search to seperate service

@roderik roderik merged commit 6f01e79 into Kunstmaan:master Jun 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment