Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Remove audio delay/pause when connecting new endpoints to composite - #13

Merged
j1elo merged 1 commit into
Kurento:masterfrom
mariogasparoni:master
Oct 22, 2020
Merged

j1elo merged 1 commit into
Kurento:masterfrom
mariogasparoni:master

Conversation

@mariogasparoni

@mariogasparoni mariogasparoni commented Oct 14, 2018 •

Copy link
Copy Markdown
Contributor

The idea is to use the start time of the first buffer as the start time of audiomixer (and not the default, 0), avoiding it to produce silence from 0 to the current running time.

Fixes Kurento/bugtracker#146
Closes #10

The idea is to use the start time of the first buffer as the start time of audiomixer (and not the default, 0), avoiding it to produce silence from 0 to the current running time.
This solves Kurento/bugtracker#146
@jenkinskurento

Copy link
Copy Markdown

Hi there. Thanks for your PR.

I'm waiting for a Kurento member to verify that this patch is reasonable to test. If it is, they should reply with check out please on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

@jenkinskurento

Copy link
Copy Markdown

There were errors, for info, please see...

@gnauhtt

gnauhtt commented Oct 14, 2019

Copy link
Copy Markdown

Has the problem been solved?

prlanzarin pushed a commit to prlanzarin/kms-core that referenced this pull request Nov 11, 2019
Improved caps comparison on agnosticbin check_bin (phantom transcoding bug)
@j1elo
j1elo merged commit fd4e1e5 into Kurento:master Oct 22, 2020
@j1elo j1elo self-assigned this Oct 22, 2020
@sshsun1990

Copy link
Copy Markdown

That's just one of the problems, I see another problem is 'audiorate' element property 'skip-to-first' is default FALSE. It also leads to use the start time of the first buffer as the start time of audiomixer, it to produce silence from 0 to the current running time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Significant delay in audio when connecting new endpoint to old composite

5 participants