Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed config-interval prop type checking in basertpendpoint and rtppaytreebin #15

Merged
merged 2 commits into from Mar 11, 2019

Conversation

Projects
None yet
4 participants
@prlanzarin
Copy link
Contributor

commented Dec 21, 2018

The property was changed from type G_UINT to G_INT (to support the value -1 for SPS/PPS at every IDR slice), but the proptype checking in kmsbasertpendpoint and kmsrtppaytreebin were not updated accordingly, so it was basically a no-op.

Reference:
https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-good/html/gst-plugins-good-plugins-rtph264pay.html at config-interval and https://lists.freedesktop.org/archives/gstreamer-commits/2016-June/094714.html.

@jenkinskurento

This comment has been minimized.

Copy link

commented Dec 21, 2018

Hi there. Thanks for your PR.

I'm waiting for a Kurento member to verify that this patch is reasonable to test. If it is, they should reply with check out please on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

@jenkinskurento

This comment has been minimized.

Copy link

commented Dec 21, 2018

There were errors, for info, please see...

@leetal

This comment has been minimized.

Copy link

commented Jan 30, 2019

See discussions here: Kurento/bugtracker#321

This PR is essentially the same as the discussed bug, but retains the old behaviour of not sending SPS/PPS information every IDR-slice (thus reducing the overall transmit from Kurento to clients as well as allowing client decoders to stabilise if lots of IDR-slices are sent)

@prlanzarin prlanzarin changed the title Fixed config-interval prop type checking in basertpendpoint Fixed config-interval prop type checking in basertpendpoint and rtppaytreebin Jan 30, 2019

@j1elo j1elo merged commit 52edb1e into Kurento:master Mar 11, 2019

@j1elo

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Are you sure this change doesn't introduce a type mismatch when using H.264?
I just found out that the H.264 parser (Gst element h264parse) uses UINT type for the config-interval property. Then the type is also checked in the getter/setter functions.

@j1elo j1elo self-assigned this Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.