Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new SCTP SDP syntax (Firefox) #16

Merged
merged 3 commits into from Jul 19, 2019

Conversation

@j1elo
Copy link
Member

commented Jul 11, 2019

Firefox moved to the newer SDP syntax for SCTP (WebRTC DataChannels), and soon enough Chrome will also do the same.

This article explains the change: How to avoid Data Channel breaking

Old style syntax:

m=application 54111 DTLS/SCTP 5000 5001 5002
a=sctpmap:5000 webrtc-datachannel 16
a=sctpmap:5001 bfcp 2
a=sctpmap:5002 t38 1

New syntax:

m=application 54111 UDP/DTLS/SCTP webrtc-datachannel
a=sctp-port:5000

This PR should fix Kurento/bugtracker#370

Other repos: Kurento/kms-elements#16

@j1elo j1elo added the enhancement label Jul 11, 2019

@j1elo j1elo self-assigned this Jul 11, 2019

@j1elo j1elo added this to In progress in Release 6.11 via automation Jul 11, 2019

@jenkinskurento

This comment has been minimized.

Copy link

commented Jul 11, 2019

Hi there, thanks for your Pull Request!

A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase test this please. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by Kurento members will still work. Regular contributors can be whitelisted to skip this step.

@j1elo j1elo changed the title [WIP] Support new SCTP SDP syntax (Firefox) Support new SCTP SDP syntax (Firefox) Jul 19, 2019

@j1elo j1elo marked this pull request as ready for review Jul 19, 2019

@j1elo j1elo merged commit 1b005c6 into master Jul 19, 2019

Release 6.11 automation moved this from In progress to Done Jul 19, 2019

@j1elo j1elo deleted the fix-datachannel-sdp branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.