Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API support for MKV profile for recordings #13

Merged
merged 2 commits into from Mar 13, 2019

Conversation

4 participants
@prlanzarin
Copy link
Contributor

commented Nov 20, 2018

This adds matroska container support for the RecorderEndpoint, which allows us to record in a format that is a bit less corruption-prone than MP4. This also allows the media server to produce varying-size stream recordings (like application screen sharing with window resizing).

The client APIs must be rebuilt to include the MKV symbols required for the RecorderEndpoint to identify the MKV profile. This goes to both the Java and JavaScript APIs.

This should be evaluted with a sibling pull request opened in the kms-core component (Kurento/kms-core#14).

@jenkinskurento

This comment has been minimized.

Copy link

commented Nov 20, 2018

Hi there. Thanks for your PR.

I'm waiting for a Kurento member to verify that this patch is reasonable to test. If it is, they should reply with check out please on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

@jenkinskurento

This comment has been minimized.

Copy link

commented Nov 20, 2018

There were errors, for info, please see...

1 similar comment
@jenkinskurento

This comment has been minimized.

Copy link

commented Nov 20, 2018

There were errors, for info, please see...

@j1elo j1elo added this to In progress in Release 6.10 via automation Feb 26, 2019

@j1elo j1elo moved this from In progress to To do in Release 6.10 Feb 26, 2019

@j1elo j1elo moved this from To do to In progress in Release 6.10 Mar 12, 2019

@@ -18,7 +18,7 @@
#include "config.h"
#endif

#define _GNU_SOURCE // Enable GNU Extensions: 'ALLPERMS' is not POSIX
#define _GNU_SOURCE // Enable GNU Extensions: 'ALLPERMS' is not POSIX

This comment has been minimized.

Copy link
@j1elo

j1elo Mar 12, 2019

Contributor

Please avoid unrelated changes

@@ -1977,8 +1979,8 @@ bus_sync_signal_handler (GstBus * bus, GstMessage * msg, gpointer data)
gst_task_pool_push (self->priv->pool, kms_recorder_endpoint_on_eos_message,
self, NULL);
} else if ((GST_MESSAGE_TYPE (msg) == GST_MESSAGE_STATE_CHANGED)
&& (GST_OBJECT_CAST (KMS_BASE_MEDIA_MUXER_GET_PIPELINE (self->
priv->mux)) == GST_MESSAGE_SRC (msg))) {
&& (GST_OBJECT_CAST (KMS_BASE_MEDIA_MUXER_GET_PIPELINE (self->priv->

This comment has been minimized.

Copy link
@j1elo

j1elo Mar 12, 2019

Contributor

Please avoid unrelated changes

@j1elo

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Looks fine; please remove the unrelated changes marked in the PR and this is ready to merge.
Sorry for the long time it took to attend this one.

@j1elo j1elo merged commit e0f7063 into Kurento:master Mar 13, 2019

Release 6.10 automation moved this from In progress to Done Mar 13, 2019

@j1elo j1elo self-assigned this Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.