This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Fix incorrect cropping in AlphaBlending element#24
Merged
Conversation
|
Hi there, thanks for your Pull Request! A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior you want to change?
When the relative X/Y is greater than zero but less than the relative width/height, the video is cropped incorrectly.
Fixes Kurento/bugtracker#63.
ie) Given
setPortProperties(0.1, 0.1, 0, 0.5, 0.5, port)results in the video being positioned at 0.1, 0.1 but only a small slice of the video is showing, the rest is cropped.What is the new behavior provided by this change?
Removing this cropping produces the expected behaviour with correct relative X, Y, width, height.
ie) Given
setPortProperties(0.1, 0.1, 0, 0.5, 0.5, port)results in the video being positioned at 0.1, 0.1 with the entire video showing, correctly scaled to 50% of the master port size.How has this been tested?
Tested in Ubuntu 18 with both latest KMS source and as a module in KMS 6.14.1 installed through apt.
Types of changes
Checklist