This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Add niceAgentIceTcp configuration option and API methods for it - #26
Merged
Conversation
This adds the ability to configure libnice`s NiceAgent ice-tcp property through WebRtcEndpoint.conf.ini or via API The rationale behind this is to give the ability to deactivate TCP candidate gathering in setups where they aren`t needed, thus potentially speeding up the gathering process and connectivity checks Property reference: https://libnice.freedesktop.org/libnice/NiceAgent.html#NiceAgent--ice-tcp
|
Hi there, thanks for your Pull Request! A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase |
Avoid leaking that the feature is internally implemented by a class named NiceAgent, which the users don't care about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior you want to change?
Currently,
ice-tcpis not explicitly set in Kurento's NiceAgent usage; therefore, it defaults toTRUE(libnice's default) and always does TCP candidate gathering.Property reference: https://libnice.freedesktop.org/libnice/NiceAgent.html#NiceAgent--ice-tcp
What is the new behavior provided by this change?
The rationale behind this is to give the ability to deactivate TCP candidate gathering in setups where they aren`t needed, thus potentially speeding up the gathering process/connectivity checks and trimming down the number of generated candidates/bound sockets.
From the WebRtcEndpoint.conf.ini:
A pair of API methods was also added to be able to control this per element:
WebRtcEndpoint.setNiceAgentIceTcp(true|false)WebRtcEndpoint.getNiceAgentIceTcpHow has this been tested?
Types of changes
Checklist