Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

RtpEndpoint library #33

Closed
wants to merge 1 commit into from

Conversation

slabajo
Copy link
Member

@slabajo slabajo commented Jul 28, 2021

What is the current behavior you want to change?

This change is reuqired to be able to implement media elements derived from RtpEndpoint like SipRtpEndpoint in https://github.com/naevatec/kms-siprtpendpoint.
No change in behaviour is intended, the rtpendpoint component should behave as it did, the change is only in its internal architecture not in how it works.

What is the new behavior provided by this change?

This change splits the RtpEndpoint GStreamer component into two elements, a library that can be included by other components, more specifically by derived components, and the GStreamer rtpendpoint component, that in turn includes the first one.

How has this been tested?

As no behaviour change is intended, the same tests that applied to rtpendpoint has been tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / enhancement (non-breaking change which improves the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • My change requires a change to the documentation
  • My change requires a change in other repository

Checklist

  • I have read the Contribution Guidelines
  • I have added an explanation of what the changes do and why they should be included
  • I have written new tests for the changes, as applicable, and have successfully run them locally

@j1elo j1elo self-assigned this Mar 14, 2022
@j1elo
Copy link
Member

j1elo commented Mar 14, 2022

@slabajo the "prepare for siprtp_module #32" PR (#32) is targeted against master branch, but this one is targeted against bionic-gstreamer branch. Any reason for that? Is it a mistake or this PR really only works together with the integration to newer GStreamer and Ubuntu systems?

@slabajo
Copy link
Member Author

slabajo commented Mar 18, 2022

No, there is nothing specific to new GStreamer, it is just that at the moment when I wrote this PR it was expected to put it in th upcoming 7.0 Kurento release, and it seemed more appropriate to make the PR against the bionic-gstreamer branch (pre 7.0 branch). However there is nothing in the PR that restricts it to bionic-gstreamer branch,

As the target is to include it in 6.17 release I can remake the PR against the master release, I am pretty sure that this commit can be directly applied in master branch

@j1elo
Copy link
Member

j1elo commented Mar 18, 2022

Changes have been integrated into the bionic-gstreamer branch, partially adapted from master, the changes found in #32, and changes in this PR.

@j1elo j1elo closed this Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants