This repository was archived by the owner on Jul 12, 2023. It is now read-only.
RtpEndpoint library#33
Closed
slabajo wants to merge 1 commit into
Closed
Conversation
Member
Member
Author
|
No, there is nothing specific to new GStreamer, it is just that at the moment when I wrote this PR it was expected to put it in th upcoming 7.0 Kurento release, and it seemed more appropriate to make the PR against the bionic-gstreamer branch (pre 7.0 branch). However there is nothing in the PR that restricts it to bionic-gstreamer branch, As the target is to include it in 6.17 release I can remake the PR against the master release, I am pretty sure that this commit can be directly applied in master branch |
Member
|
Changes have been integrated into the bionic-gstreamer branch, partially adapted from master, the changes found in #32, and changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior you want to change?
This change is reuqired to be able to implement media elements derived from RtpEndpoint like SipRtpEndpoint in https://github.com/naevatec/kms-siprtpendpoint.
No change in behaviour is intended, the rtpendpoint component should behave as it did, the change is only in its internal architecture not in how it works.
What is the new behavior provided by this change?
This change splits the RtpEndpoint GStreamer component into two elements, a library that can be included by other components, more specifically by derived components, and the GStreamer rtpendpoint component, that in turn includes the first one.
How has this been tested?
As no behaviour change is intended, the same tests that applied to rtpendpoint has been tested
Types of changes
Checklist