This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Repository navigation
fix: remove lib error-tojson and add method locally to stringify error - #10
Merged
Merged
Conversation
Contributor
|
Hi there, thanks for your Pull Request! A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase |
Member
|
Thanks! Hopefully this solves all issues with 3rd party dependencies that might have been giving problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior you want to change?
As discussed here, this code adds a new file that does what the error-tojson library (which has been removed) did, only without compatibility issues.
What is the new behavior provided by this change?
Add errorToJson file to add toJSON method to stringify error
How has this been tested?
The simple way to test is to check if the toJSON method exists, then check if when called it generates an object with the stack and message attributes.
And to check if there is no more conflict, just try to add a new function for Error.prototipy.toJSON.
Types of changes
Checklist