Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

fix: remove lib error-tojson and add method locally to stringify error - #10

Merged
j1elo merged 1 commit into
Kurento:masterfrom
marcosdourado:master
Jun 24, 2020
Merged

j1elo merged 1 commit into
Kurento:masterfrom
marcosdourado:master

Conversation

@marcosdourado

Copy link
Copy Markdown
Contributor

What is the current behavior you want to change?

As discussed here, this code adds a new file that does what the error-tojson library (which has been removed) did, only without compatibility issues.

What is the new behavior provided by this change?

Add errorToJson file to add toJSON method to stringify error

How has this been tested?

The simple way to test is to check if the toJSON method exists, then check if when called it generates an object with the stack and message attributes.

And to check if there is no more conflict, just try to add a new function for Error.prototipy.toJSON.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / enhancement (non-breaking change which improves the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • My change requires a change to the documentation
  • My change requires a change in other repository

Checklist

  • I have read the Contribution Guidelines
  • I have added an explanation of what the changes do and why they should be included
  • I have written new tests for the changes, as applicable, and have successfully run them locally

@jenkinskurento

Copy link
Copy Markdown
Contributor

Hi there, thanks for your Pull Request!

A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase test this please. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by Kurento members will still work. Regular contributors can be whitelisted to skip this step.

@j1elo
j1elo merged commit af8ddb8 into Kurento:master Jun 24, 2020
@j1elo

j1elo commented Jun 24, 2020

Copy link
Copy Markdown
Member

Thanks! Hopefully this solves all issues with 3rd party dependencies that might have been giving problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants