This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Repository navigation
Fix memory leak in JavaScript Client - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior you want to change?
Kurento node client keeps a cache of instantiated Kurento elements in an 'objects' variable. That registry of instatiated objects should be maintained along with kurento object creation and release. However the release procedure has two problems:
What is the new behavior provided by this change?
This PR, fixes two issues:
How has this been tested?
On a Kurento tutorial, specifically Hello World node tutorial, we get a heap dump before change, where we can observe that no Kurento element is removed from cache, and thus all Kurento objects are retained by that cache. Once the change is applied, we execute the same procedure and see that heapdump shows no instances in cache, nor objects in hepadump
Types of changes
Checklist