Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket connection options #2

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@tomhouman
Copy link
Contributor

commented May 2, 2016

  • Forward WebSocket connection options to reconnect-ws when constructing KurentoClient instance.
@tgabi333

This comment has been minimized.

Copy link

commented May 13, 2016

This should solve Kurento/bugtracker#67

@tomhouman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2016

Yes, this will solve bug #67. This enables full mutually authenticated TLS connections to KMS. You simply provide the proper socket options for your TLS configuration as you would with a standard socket. The reconnect library consumes the options and keeps the socket alive.

@tgabi333

This comment has been minimized.

Copy link

commented Jun 28, 2016

@tomhouman Could you please not merge master branch but rebase your commits onto master? Its could ease the pull request process.

@tomhouman tomhouman force-pushed the tomhouman:master branch from 599a5ea to ce712a0 Jun 28, 2016

@tomhouman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2016

@tgabi333 No problem, sorry I didn't notice the mess. Rebase is done.

@interfaith

This comment has been minimized.

Copy link

commented Jul 9, 2016

using "free" certs from startssl.com
all the demos give the same error with any kind of cert

janus did not have THIS bug.. but it does have android issues
every upgrade is a thrill

index.js:70 reconnect to server 22 10000 undefined
kurento-client.js:29012 WebSocket connection to 'wss://tra:8433/kurento' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
index.js:70 reconnect to server 23 10000 undefined
kurento-client.js:29012 WebSocket connection to 'wss://tra.com:8433/kurento' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
index.js:70 reconnect to server 24 10000 undefined
kurento-client.js:29012 WebSocket connection to 'wss://tra:8433/kurento' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED

@Nosere

This comment has been minimized.

Copy link

commented Mar 10, 2018

this issue is still not fixed

@jenkinskurento

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2018

Hi there. Thanks for your PR.

I'm waiting for a Kurento member to verify that this patch is reasonable to test. If it is, they should reply with check out please on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

@jenkinskurento

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2018

There were errors, for info, please see...

1 similar comment
@jenkinskurento

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2018

There were errors, for info, please see...

@j1elo j1elo added this to In progress in Release 6.11 via automation Apr 5, 2019

@j1elo j1elo self-assigned this Apr 9, 2019

@j1elo j1elo moved this from In progress to To do in Release 6.11 Apr 17, 2019

@j1elo j1elo merged commit eb2c332 into Kurento:master Jul 19, 2019

1 check failed

deploy to staging site Something went wrong. Investigate! No test results found.
Details

Release 6.11 automation moved this from To do to Done Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.