Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update utf-8-validate to the latest #4

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@yonghongren
Copy link
Contributor

commented May 18, 2019

utf-8-validate uses 'nan'. The older versions use 'ForceSet' that has been removed from new Node.js. Update to the latest version allows the package to be used with newer versions of Node.js.

Yonghong Ren
update utf-8-validate to the latest
utf-8-validate uses 'nan'. The older versions use 'ForceSet' that has been removed from new Node.js
@jenkinskurento

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

Hi there, thanks for your Pull Request!

A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase test this please. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by Kurento members will still work. Regular contributors can be whitelisted to skip this step.

@j1elo j1elo self-assigned this May 23, 2019

@j1elo j1elo added this to In progress in Release 6.11 via automation May 23, 2019

@j1elo j1elo merged commit 8d1dd64 into Kurento:master Jul 19, 2019

Release 6.11 automation moved this from In progress to Done Jul 19, 2019

@j1elo j1elo referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.