Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

WebSocketTransport: allow to set listen address in config (fixes kurento/bugtracker#518 and kurento/bugtracker#290) - #21

Merged
j1elo merged 1 commit into
Kurento:masterfrom
Craeckie:websocket-address
Jul 7, 2022
Merged

WebSocketTransport: allow to set listen address in config (fixes kurento/bugtracker#518 and kurento/bugtracker#290)#21
j1elo merged 1 commit into
Kurento:masterfrom
Craeckie:websocket-address

Conversation

@Craeckie

@Craeckie Craeckie commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

What is the current behavior you want to change?

Resolves Kurento/bugtracker#518 and Kurento/bugtracker#290 to allow the server admin to specify a listen address for the websocket server. This way the port doesn't have to be exposed to the internet.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / enhancement (non-breaking change which improves the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • My change requires a change to the documentation
  • My change requires a change in other repository

Checklist

  • I have read the Contribution Guidelines
  • I have added an explanation of what the changes do and why they should be included
  • I have written new tests for the changes, as applicable, and have successfully run them locally

@j1elo j1elo self-assigned this Jul 7, 2022
@j1elo
j1elo merged commit d247e88 into Kurento:master Jul 7, 2022
@j1elo

j1elo commented Jul 7, 2022

Copy link
Copy Markdown
Member

Thank you very much! This is a nice addition for people that need or want to customize the WebSocket listening port

j1elo added a commit that referenced this pull request Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control plane authentication

2 participants