Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Add KurentoModuleCreatorConfig with path to FindKurentoModuleCreator #3

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

pabs3
Copy link
Contributor

@pabs3 pabs3 commented Jun 16, 2021

Just use the same path as KurentoModuleCreatorConfig for simplicity.

cmake find_package() cannot find FindKurentoModuleCreator by default but
KurentoModuleCreatorConfig is found by default and can then update the
modules directory list to include the path FindKurentoModuleCreator is in.

The cmake version-specific modules dir can also be used but
that reqires updating every time a new cmake version is released.

See-also: https://cmake.org/cmake/help/latest/command/find_package.html#basic-signature-and-module-mode

Just use the same path as KurentoModuleCreatorConfig for simplicity.

cmake find_package() cannot find FindKurentoModuleCreator by default but
KurentoModuleCreatorConfig is found by default and can then update the
modules directory list to include the path FindKurentoModuleCreator is in.

The cmake version-specific modules dir can also be used but
that reqires updating every time a new cmake version is released.

See-also: https://cmake.org/cmake/help/latest/command/find_package.html#basic-signature-and-module-mode
@jenkinskurento
Copy link

Hi there, thanks for your Pull Request!

A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase test this please. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by Kurento members will still work. Regular contributors can be whitelisted to skip this step.

@pabs3
Copy link
Contributor Author

pabs3 commented Jun 16, 2021 via email

@j1elo
Copy link
Member

j1elo commented Jun 17, 2021

The original authors of Kurento did some serious CMake magic around the logic to find modules and such... and it hasn't essentially changed at all since then. But I guess everything is prone to improvements.

Note that most Kurento modules can be installed for usage (typical scenario), or for writing custom plugins based on the module, which is what people do to write their own Kurento modules. So both use cases must be considered in all these files.

I guess this wouldn't really break any development setup that depends on these modules right?

@pabs3
Copy link
Contributor Author

pabs3 commented Jun 17, 2021 via email

@j1elo j1elo self-assigned this Mar 18, 2022
@j1elo j1elo merged commit 102b594 into Kurento:master Mar 18, 2022
@pabs3 pabs3 deleted the add-cmake-config-file branch March 18, 2022 23:24
@pabs3
Copy link
Contributor Author

pabs3 commented Mar 18, 2022

Thanks for merging folks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants