Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kurento-recorder demo to record video #3

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@xenyou
Copy link
Contributor

commented Oct 27, 2017

callback is not called for client.connect.
so the video is not recorded.

@jenkinskurento

This comment has been minimized.

Copy link

commented Oct 27, 2017

Hi there. Thanks for your PR.

I'm waiting for a Kurento member to verify that this patch is reasonable to test. If it is, they should reply with check out please on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

@jenkinskurento

This comment has been minimized.

Copy link

commented Oct 27, 2017

There were errors, for info, please see...

@sujeeth16
Copy link

left a comment

This solution works

@soogly

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

I found this bug today and push commit with fix, but it were ignored.
Or I'am don't undestand something =/

@lengerrong

This comment has been minimized.

Copy link

commented Dec 25, 2018

This solution really works, why the commit not accepted!!!

j1elo added a commit that referenced this pull request Jul 22, 2019

Revert "Remove needless parameter from `client.connect` method call (#7
…)"

Reverts #7
I just realized that this would break the loopback connection (browser webrtc to itself, so the user is able to see her own webcam image).
Correct solution is the one shown in #3

@j1elo j1elo merged commit a510d8f into Kurento:master Jul 22, 2019

1 check failed

deploy to staging site Something went wrong. Investigate! No test results found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.