Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with needless parameter #7

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@soogly
Copy link
Contributor

commented Oct 31, 2018

In the calling of the method client.connect parameter webRrt is given twice.
It doesn't raise any error, but prevents connect.

@jenkinskurento

This comment has been minimized.

Copy link

commented Oct 31, 2018

Hi there. Thanks for your PR.

I'm waiting for a Kurento member to verify that this patch is reasonable to test. If it is, they should reply with check out please on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

@jenkinskurento

This comment has been minimized.

Copy link

commented Nov 1, 2018

There were errors, for info, please see...

@j1elo j1elo self-assigned this Jul 22, 2019

@j1elo j1elo added this to In progress in Release 6.11 via automation Jul 22, 2019

@j1elo j1elo merged commit c6a5c24 into Kurento:master Jul 22, 2019

1 check failed

deploy to staging site Something went wrong. Investigate! No test results found.
Details

Release 6.11 automation moved this from In progress to Done Jul 22, 2019

j1elo added a commit that referenced this pull request Jul 22, 2019

j1elo added a commit that referenced this pull request Jul 22, 2019

Revert "Remove needless parameter from `client.connect` method call (#7
…)"

Reverts #7
I just realized that this would break the loopback connection (browser webrtc to itself, so the user is able to see her own webcam image).
Correct solution is the one shown in #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.