Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating uuid to 3.2.1 version #24

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@aenriquezgentile
Copy link
Contributor

commented May 12, 2018

Updating to latest version of uuid was needed in order to make kurento-utils work with angular 6 (webpack 4).

With uuid 2.0.1 the angular app was not starting and showing the error:
referenceerror: global is not defined at rng-browser.js

@jenkinskurento

This comment has been minimized.

Copy link
Contributor

commented May 12, 2018

Hi there. Thanks for your PR.

I'm waiting for a Kurento member to verify that this patch is reasonable to test. If it is, they should reply with check out please on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

@jenkinskurento

This comment has been minimized.

Copy link
Contributor

commented May 12, 2018

There were errors, for info, please see...

@j1elo j1elo self-assigned this Jul 22, 2019

@j1elo j1elo self-requested a review Jul 22, 2019

@j1elo j1elo added this to In progress in Release 6.11 via automation Jul 22, 2019

@j1elo j1elo removed their request for review Jul 22, 2019

@j1elo j1elo merged commit 0c153ad into Kurento:master Jul 22, 2019

Release 6.11 automation moved this from In progress to Done Jul 22, 2019

@aenriquezgentile

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

Hello, with uuid version 3.0.0 I'm still getting the error:
referenceerror: global is not defined at rng-browser.js

@j1elo

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Hi, version is not 3.0.0, but ^3.0.0, which should resolve to the latest 3.x version, eg. right now for me, npm install resolves uuid to version 3.3.2. Why is it not resolving for you?

Check out these commands:

$ npm install
$ npm ls uuid
kurento-utils@6.11.0 /home/kurento/kurento-utils-js
├─┬ chromedriver@74.0.0
│ └─┬ request@2.88.0
│   └── uuid@3.3.2  deduped
├─┬ coveralls@2.11.16
│ └─┬ request@2.79.0
│   └── uuid@3.3.2  deduped
└── uuid@3.3.2

Anyhow, I've read more about this bug and it was fixed in uuid v3.2.1 so I agree the dependency should be ^3.2.1 instead of ^3.0.0. I'll change it.

@aenriquezgentile

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

Ok, great if you change it to ^3.2.1 version.

I don't know what happens for me but I installed the kurento-utils version 6.11.0 and I still see uuid set to "uuid": "~2.0.1" in kurento-utils/package.json. Thus I'm still getting the error with ^6.11.0

@j1elo

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

I am sorry; my bad!
A mistake publishing the package meant that the version 6.11.0 didn't bring the needed changes.

I've published a patch with everything needed, so you should find that the new kurento-utils 6.11.1 is working as expected, should bring uuid version 3.3.

@aenriquezgentile

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

No problem! All fine for me now.

Anyway kurento-utils 6.11.1 still has uuid ^3.0.0 instead of ^3.2.1. Other people could get a lower version than ^3.2.1 installed and still get the error.

Thanks.

@j1elo

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

yeah I just republished the package, and the 3.2.1 change will ship in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.