Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
support for generating documents with Apache FOP #2
I'm not able to merge this commit at the moment and here's why:
More importantly, we discussed previously whether you could add smaller pull requests so that it's easier to track the changes through the project. This is not just for my own benefit as a reviewer, but also for those that wish to dig into how the project has grown over time.
Saying that, this looks like a great addition to the project! I especially like the initial table layout you seem to have done. I'd be happy to merge this pull request if you can do the following:
I did update project.clj, but forgot to add it to the commit. I've just corrected this.
Everything is working as intended here. Could you be more specific about your problem with clojure.xml? I suppose you mean clojure.data.xml, by the way, because I'm not using clojure.xml in this code. EDIT: I just realized what the problem must have been: that library is also included in the project.clj file I forgot to include.
As to the single commit: everything I added in this patch is connected and pointless to check in or test by itself. There is only one function that uses Apache FOP (write-pdf!). The rest is all XML formatting. It would be possible to single write-pdf! out in a separate commit, but are you sure this is worth it? I understand your point, but while correct in theory this method doesn't really fit the code in question.
Because the markup language is called FO (see http://en.wikipedia.org/wiki/XSL_Formatting_Objects). I figured a "fo" module would be a more logical fit because it describes the method of creating PDF files (as opposed to e.g. PDFBox) instead of the tool. Apache FOP is abstracted away in this module, so the most relevant part seems to be the markup language.
added a commit
this pull request
May 3, 2012
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I've separated the fo namespace out into a separate .jar, because I wanted the convenience of being able to add it as a Maven dependency (since it is currently not part of the Camelot jar). See https://github.com/fmw/clj-fo
When and if you decide to release a new jar I can remove the clj-fo project and point it to Camelot (assuming you have time to merge in possible new code I'm adding in the future). It is also fine with me to split the two projects.