fix merge-pdfs function #4

Merged
merged 1 commit into from May 13, 2013

2 participants

@cap10morgan

I tried writing a test around this, but I couldn't solve some major bugs with the save-as function. For one, it returns an empty PDF no matter what you write to it. This is because .close gets called on it first. But fixing that didn't solve the problem for some reason.

Also, create-pdf-helper puts the text into a map with :text as its key, but save-as doesn't appear to do anything with that. However, changing it use :lines [[{} text]] instead also didn't fix it.

So I'm kind of stumped there.

However, this does fix the problem of merge-pdfs just repeating the 2nd page over and over.

@KushalP
Owner

Thanks!

I'll get a release out to clojars later this evening or tomorrow.

@KushalP KushalP merged commit 627a273 into KushalP:master May 13, 2013

1 check passed

Details default The Travis CI build passed
@cap10morgan cap10morgan deleted the democracyworks:fix-merge-pdfs branch Aug 5, 2013
@cap10morgan

Any chance we can get a new release with this fix merged in?

@KushalP
Owner

Sorry this wasn't done sooner. The comment ended up in my spam folder. I just made a new release: 0.2.1.

Link: https://clojars.org/camelot

@cap10morgan

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment