Timeout and color config, fix dimensions, pull in loaders.css, SSR, currentColor, spinnerName#58
Conversation
| 75% { -webkit-transform: translateX(0px) translateY(22px) rotate(-270deg) scale(0.5) } | ||
| 25% { -webkit-transform: translateX(42px) rotate(-90deg) scale(0.5) } | ||
| 50% { -webkit-transform: translateX(42px) translateY(42px) rotate(-180deg) } | ||
| 75% { -webkit-transform: translateX(0px) translateY(42px) rotate(-270deg) scale(0.5) } |
There was a problem hiding this comment.
Not sure why these weren't on the same 42px scale as the non-vendor-prefixed keyframes, so I adjusted them. If there was a reason, I'm happy to revert.
| @@ -1,3 +1,7 @@ | |||
| .sk-three-bounce { | |||
| height: 18px; | |||
| } | |||
There was a problem hiding this comment.
user-agent default styles added padding to the bottom of this div that affected proper vertical alignment.
3ea413d to
75f5640
Compare
|
Second commit refactors everything to be classed-divs with anonymous children divs so that code can be DRYed, relying heavily on the suggestion in #27. This should make on-boarding future loader repos easier. Also makes it so that all spinners accept colorization. Additionally, fixed a bug in the CSS for the Also does a similar thing for the demos page, using iteration to render all spinners (with colored versions too). |
| @@ -0,0 +1,52 @@ | |||
| .ball-triangle-path > div, | |||
There was a problem hiding this comment.
Minor overrides to loaders.css styles to allow coloring under new scheme.
|
This also addresses #53 indirectly. |
|
Since this represents a lot of changes, pulled in #19 as well, and maybe this could result in a 3.0 release. |
|
This is awesome! Thanks for giving things a nice cleanup / upgrade! Adding colors support + loaders.css is 💯 Merging and releasing a 3.0. The next frontier I see for this module is adding tree shaking support. That or perhaps switch to a lerna monorepo approach where there's a package per spinner to keep the size of the package to a minimum. |
This PR addresses a few issues:
noFadeInprop with a deprecation warning.process.env.PRODUCTIONand is a specific enough variable that it shouldn't collide.Additionally, updated tests, README, and demo site for all new features, and made changes to the test file to appease eslint (change to
.jsx, convert tabs to spaces, etc) as well as organizational improvements (describe blocks to group related tests).All changes were tested inside of a working app for functionality and proper centering alignment.