Kyle Mathews KyleAMathews

KyleAMathews commented on pull request KyleAMathews/react-modal#1
@KyleAMathews

Perhaps test again that the class is gone after closing the modal? (Thanks!)

KyleAMathews commented on pull request rackt/react-modal#41
@KyleAMathews

That'd be great! On Mon, Jun 1, 2015 at 3:21 PM Andy Brown notifications@github.com wrote: That makes sense. I can add some test coverage of this. —…

KyleAMathews commented on pull request rackt/react-modal#41
@KyleAMathews

That was my initial thought—to add it to the app element—but there's no reason the class should be put there and it's more generally useful if put …

KyleAMathews commented on issue rackt/react-modal#29
@KyleAMathews

@astephenb created PR if you'd like to test.

@KyleAMathews
@KyleAMathews
  • @KyleAMathews 39b4f9f
    Add class to body when modal is open fixes #29
KyleAMathews opened pull request rackt/react-modal#41
@KyleAMathews
Add class to body when modal is open fixes #29
2 commits with 20 additions and 13 deletions
KyleAMathews commented on issue rackt/react-modal#29
@KyleAMathews

Ran into the same problem. Will work on a patch for this Monday.

@KyleAMathews
  • @KyleAMathews 893acd1
    react-tools should not be in peerDependencies
KyleAMathews commented on issue gka/chroma.js#64
@KyleAMathews

Cool, this makes sense. I just use .css() generally so it's not an active problem, just noticed it once while exploring.

KyleAMathews commented on issue gka/chroma.js#64
@KyleAMathews

This... seems more clever than useful :) Is compatibility with browsers not the goal? They would say black is hsl(0, 0%, 0%)

@KyleAMathews

Released a 1.1.2. Hopefully a longer-lived release :)

@KyleAMathews
@KyleAMathews
@KyleAMathews
@KyleAMathews

Oh right... grr... didn't think about this very much. Yeah, I'll return it to PropType string and make default "" and check if the override prop is…