Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Account Authentication not using internal Web Browser #89

Closed
Kyrodan opened this issue Jun 1, 2017 · 10 comments
Closed

Reimplement Account Authentication not using internal Web Browser #89

Kyrodan opened this issue Jun 1, 2017 · 10 comments
Milestone

Comments

@Kyrodan
Copy link
Owner

Kyrodan commented Jun 1, 2017

Completely reimplement account authentication:

  • remove WebView in favor of using System's Default Web Browser
  • use internal (loopback) server instead of "URL/Document Title catching" (where possible)

Reasons:

@BurningEnlightenment
Copy link

BurningEnlightenment commented Jun 9, 2017

FYI there is an ietf draft regarding oauth2 in native applications which might be helpful: https://tools.ietf.org/html/draft-ietf-oauth-native-apps-11#page-2
There is also a netstandard1.4 & net452 implementation of said draft: https://github.com/IdentityModel/IdentityModel.OidcClient2
HTH
EDIT: ooops, totally missed that the ietf draft was mentioned in the linked google blog post 🙈

@univerio
Copy link

@Kyrodan Here's an idea: what if we have a trampoline page hosted on an SSL domain, that just uses JS to redirect to a localhost URL, effectively bypassing all of the SSL, port, and URL fragment restrictions?

@BurningEnlightenment
Copy link

BurningEnlightenment commented Oct 20, 2017

@Kyrodan have you begun implementing this feature? If yes, can I help speeding things up in some way? If not, would you mind if I start implementing?
Oh, btw: the ietf draft became an RFC by now: https://tools.ietf.org/html/rfc8252

@Kyrodan
Copy link
Owner Author

Kyrodan commented Oct 23, 2017

Hi @BurningEnlightenment I haven't begun with this issue.
A Pull Request for that is welcome.
But please be aware: Not all provides currently implement this RFC. So you have to check it for every provider.

@BurningEnlightenment
Copy link

BurningEnlightenment commented Mar 20, 2018

Microsoft finally implemented the PKCE RFC in Azure AD via the v2 Endpoint 🎉

(on a side note: I stopped working on this back then after I figured that it wouldn't work with OneDrive, so maybe I will give it another shot next month or so)

@marcomsousa
Copy link

I wasn't able to add my Google Drive Account.
Using last version about both the plugin and the KeePass. and Windows 10 Last version.

I was able to put my username/password and TFA PIN, but when Google show the allow or denied button grayed-out I can't press them.
Maybe because of incompatible with Web Browser, or deprecated..

@marcomsousa
Copy link

marcomsousa commented Feb 14, 2020

To fix issue my suggestion is to implement the same way as Cyberduck application.

When you choose the Google Drive, it open the Google Authentication/Verification in the default browser (outside the Application).
When to complete Google will give you a code to Copy it.
image

This Google oauth2 is configured as a Native App, the url is:
https://accounts.google.com/o/oauth2/approval/v2/approvalnativeapp?auto=false&response=state

Inside the Application you have a Google Drive windows to past the code retrieve in the browser:
image

This solutions should be easy to implement, is more or less just deleting code lines :-D

@Turiok
Copy link

Turiok commented Feb 17, 2020

Hi,

If I understand well, my bug is caused because this feature is not implemented.
So sync with gdrive is impossible?
Or someone found a workaround?

#212

@alabamatoy
Copy link

alabamatoy commented Apr 13, 2020

I appear to be broken as well. This link: https://accounts.google.com/o/oauth2/approval/v2/approvalnativeapp?auto=false&response=state Simply brings a 404 not found error.

@Kyrodan
Copy link
Owner Author

Kyrodan commented May 18, 2021

Releases v2.0.0 today.

@Kyrodan Kyrodan closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants