Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cases in functional tests #16

Closed
wants to merge 116 commits into from
Closed

Fix cases in functional tests #16

Changes from all commits
Commits
Show all changes
116 commits
Select commit Hold shift + click to select a range
7bd6ff5
Initial commit
Aug 14, 2017
5881c77
Initial commit
Aug 14, 2017
6a8643b
Merge remote-tracking branch 'remotes/origin/20170814-bondarenko-1819…
Aug 14, 2017
2be07fa
Merge branch 'dev-20170814-bondarenko-18199-video-tools-implementatio…
Aug 14, 2017
a5b6fdd
Improve StreamsInfo and FramesMonitor constructors
Aug 15, 2017
b6f208c
Add tests, package.json and yarn lock
Aug 15, 2017
8889103
Update README.md file
Aug 16, 2017
864cd80
Update package.json file
Aug 16, 2017
64d8500
Add LICENSE file
Aug 16, 2017
c651821
Fix tests
Aug 16, 2017
e4effd7
Update package.json
Aug 16, 2017
da64dd7
Update StreamsInfo class
Aug 16, 2017
59d89b2
add eslintrc and eslintignore file
Aug 16, 2017
ccf0ac1
Update tests
Aug 17, 2017
225febd
Update StreamsInfo class. Wrap JSON.parse call
Aug 17, 2017
7c833dd
Increase timeout in func tests
Aug 17, 2017
c73c892
Update package.json file
Aug 17, 2017
ead8c6a
Add listen param to ffmpeg command. Listen http in tests.
Aug 17, 2017
6dff245
Fix eslint issues & add Helpers dir
Aug 18, 2017
a2fd9d6
Fix eslint issues
Aug 18, 2017
6ce9d81
Add newline at EOF
Aug 18, 2017
680cb84
add eslint to package json, fix scripts
Aug 18, 2017
b0505a9
Add yarn.lock
Aug 18, 2017
c457e60
StreamsInfo constructor test refactoring (refs #18200)
Aug 18, 2017
fb9dbd1
StreamsInfo _findGcd, _calculateDisplayAspectRatio test refactoring (…
Aug 18, 2017
0f0275d
StreamsInfo _adjustAspectRatio test refactoring (refs #18200)
Aug 18, 2017
2733608
StreamsInfo _adjustAspectRatio test refactoring (refs #18200)
Aug 18, 2017
27da304
StreamsInfo _parseStreamsInfo and fetch test refactoring (refs #18200)
Aug 18, 2017
74a8674
package.json update (refs #18200)
Aug 18, 2017
b837c3a
fix tests
Aug 18, 2017
bc10424
Add check if stdout is string or empty
Aug 18, 2017
a95ce0c
Update tests, rewrite from BDD to TDD. Find free port.
Aug 21, 2017
5ed73b7
Concretize error message
Aug 21, 2017
ea5e02f
Add deps inside package.json
Aug 21, 2017
f784859
update yarn lock file
Aug 21, 2017
0833c7c
Minor fix
Aug 21, 2017
4088c59
Change folder structure
Aug 21, 2017
35f4897
Apply code style for all files
Aug 21, 2017
2512313
Improve func test for the StreamsInfo::fetch method
Aug 21, 2017
2af1ce9
Fix eslint warnings
Aug 21, 2017
7b2ded7
Improve fetch func test
Aug 21, 2017
b9174ad
Merge branch 'dev-20170815-bondarenko-18200-streams-info-tests' into …
Aug 21, 2017
662a1d9
Move unit tests under the Unit folder
Aug 21, 2017
d104b48
Merge branch 'dev-20170815-bondarenko-18200-streams-info-tests' into …
Aug 21, 2017
8fbfbe8
Fix constructor, minor fixes
Aug 21, 2017
55b88d5
Add unit tests for FramesMonitor::constructor
Aug 21, 2017
2d127e0
rename _frameToJSON method to _frameToJson
Aug 21, 2017
2fdc3b3
Add tests for FramesMonitor::_frameToJson method
Aug 21, 2017
2a404fc
Minor fix for frames monitor class
Aug 22, 2017
b71eb32
add unit tests for _reduceFramesFromStdoutBuffer method
Aug 22, 2017
e9e05e1
Update README.md
Aug 22, 2017
995a666
Check if chunk has a type Buffer (refs #18201)
Aug 22, 2017
322dcf2
Add test for _onStdoutChunk method (refs #18201)
Aug 22, 2017
6038959
Set cp to null when stop listen (refs #18201)
Aug 22, 2017
036679e
Add unit tests for listen and stopListen methods (refs #18201)
Aug 22, 2017
031aff6
Add unit tests for isListening method (refs #18201)
Aug 23, 2017
5360cf0
Add unit tests for _onExit method (refs #18201)
Aug 23, 2017
8cca85d
Add helper object into Helpers (refs #18201)
Aug 23, 2017
b222eab
stub -> spy (refs #18201)
Aug 23, 2017
33c0080
Process error event in separate function
Aug 23, 2017
beafca7
Update helper
Aug 23, 2017
f05f30f
Update tests
Aug 23, 2017
93c2db9
Add unit tests for listen, isListen, stopListen and private methods. …
Aug 25, 2017
7d36d84
Minor refactoring
Aug 25, 2017
fb76766
remove isBuffer check, setImmediate -> nextTick and _.isPlainObject c…
Aug 28, 2017
6353874
Update tests
Aug 28, 2017
e0c6d0b
Get rid of nextTick
Aug 29, 2017
b0dc1c0
Update tests
Aug 29, 2017
a77a682
Add func tests for FramesMonitor class
Aug 29, 2017
87b27e4
Add signal param for stopListen method
Sep 5, 2017
b0edea6
Fix typo (refs #18202)
Sep 5, 2017
0e59cec
Refactor and test FramesMonitor and FramesEmitter classes (refs #18201)
Sep 4, 2017
6f7879e
Minor fix (refs #18202)
Sep 5, 2017
7faf30b
Make FramesReducer::process sync and fix tests (refs #18201)
Sep 6, 2017
b8dbd39
Fix tests (refs #18201)
Sep 6, 2017
b68e48a
migrate code to classes (refs #18201)
Sep 6, 2017
6379af8
Add toString call for process stderr, minor fixes (refs #18201)
Sep 6, 2017
5c5b55a
Merge branch 'dev-20170828-bondarenko-18201-frames-monitor-func-tests…
Sep 7, 2017
bd2a70e
Fix tests after merge (refs #18201)
Sep 7, 2017
275a1fa
Fix ffprobe run command and tests
Sep 7, 2017
9829c72
Join reducer with monitor class, adjust tests (refs #18201)
Sep 11, 2017
bc8fbd0
Merge branch 'dev-20170821-bondarenko-18201-frames-monitor-all-tests'…
Sep 11, 2017
66a94d1
move from FramesInfo class to processFrames function, fix tests (#ref…
Sep 5, 2017
602c646
Add func test, temporary comment checks for some values from ffmpeg (…
Sep 7, 2017
1bf1f19
Adjust code & fix tests (refs #18202)
Sep 12, 2017
f60ee4c
Fix code according to MR comments (refs #18202)
Sep 13, 2017
7ddef21
Merge branch 'dev-20170905-bondarenko-18202-processFrames-tests' into…
Sep 13, 2017
e796111
Remove out of date deps, update yarn.lock and exports Errors object
Sep 14, 2017
0b631ae
Merge branch 'dev-20170914-bondarenko-18347-adjust-code-fixes' into '…
Sep 15, 2017
6472915
Add signal param to stopListen call (refs #18368)
Sep 20, 2017
1594971
Return remain frames after process (refs #18372)
Sep 21, 2017
87648ee
Merge remote-tracking branch 'remotes/origin/dev-20170920-bondarenko-…
Sep 21, 2017
9629b3d
Fix minor comments after review (refs #18372)
Sep 22, 2017
911e7e4
Merge remote-tracking branch 'remotes/origin/dev-20170921-bondarenko-…
Sep 22, 2017
d7fcfb1
Refactor tests in order to use helpers functions (refs #18375)
Sep 22, 2017
6acdc16
Merge remote-tracking branch 'remotes/origin/dev-20170921-bondarenko-…
Sep 22, 2017
c746fcd
Set cp to null only within exit event, move error level to config (re…
Oct 9, 2017
a6decd5
Merge branch 'dev-20170921-bondarenko-18471-minor-fixes' into 'master'
Oct 20, 2017
cdbbdb0
return promise from stopListen, emit reasons with an exit event.
Nov 3, 2017
c299b01
Fix remarks after review (refs #18603)
Nov 6, 2017
2612e8b
Move setImmediate call down to bottom in order to correct process pro…
Nov 6, 2017
ecbe412
Fix issue with child process, check error within promise (refs #18603)
Nov 6, 2017
41c7226
Merge branch 'dev-20171103-bondarenko-18603-fix-code-according-to-spe…
Nov 6, 2017
cfecd01
innerStopListen -> _handleProcessingError, fix promise resolve (refs …
Nov 6, 2017
3643e9d
call stopListen from _handleProcessingError method (refs #18614)
Nov 6, 2017
36439eb
Merge branch 'dev-20171103-bondarenko-18614-fix-innerStopListen-metho…
Nov 7, 2017
3f3f1f6
Make _assertExecutable static, bind methods in constructor (refs #18616)
Nov 7, 2017
e46cd3c
Merge branch 'dev-20171129-bondarenko-18616-minor-fixes' into 'master'
Nov 7, 2017
d50a44f
Add unit and func tests (refs #18605)
Nov 7, 2017
c4ec27c
Update README.md file (refs #18625)
Nov 8, 2017
47d1d5a
Merge branch 'dev-20171108-bondarenko-18625-update-readme' into 'master'
Nov 13, 2017
67bb0c6
Fix tests according to comments (refs #18605)
Nov 13, 2017
615aafa
Merge branch 'dev-20171106-bondarenko-18605-fix-code-according-to-spe…
Nov 13, 2017
b9fd11a
Merge remote-tracking branch 'origin/master'
Sep 7, 2018
f3a54d6
Merge remote-tracking branch 'origin/master'
oleh-poberezhets Oct 3, 2018
a24f8ff
fix functional tests
oleh-poberezhets Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/Functional/processFrames.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ describe('processFrames functional tests', () => {
fps: {mean: expectedMeanFps, min: expectedMinFps, max: expectedMaxFps},
bitrate: {mean: expectedMeanBitrate, min: expectedMinBitrate, max: expectedMaxBitrate},
gopDuration: {mean: expectedMeanGop, min: expectedMinGop, max: expectedMaxGop},
aspectRatio: expectedAspectRatio,
displayAspectRatio: expectedAspectRatio,
height: expectedHeight,
width: expectedWidth,
hasAudioStream: expectAudio
Expand Down Expand Up @@ -168,7 +168,7 @@ describe('processFrames functional tests', () => {
fps: {mean: expectedMeanFps, min: expectedMinFps, max: expectedMaxFps},
bitrate: {mean: expectedMeanBitrate, min: expectedMinBitrate, max: expectedMaxBitrate},
gopDuration: {mean: expectedMeanGop, min: expectedMinGop, max: expectedMaxGop},
aspectRatio: expectedAspectRatio,
displayAspectRatio: expectedAspectRatio,
width: expectedWidth,
height: expectedHeight,
hasAudioStream: expectAudio
Expand Down