Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add requestgroups pages #4

Merged
merged 19 commits into from Aug 27, 2020
Merged

Conversation

eheinrich
Copy link
Contributor

Pulled over components for the compose, request detail, and requestgroup detail pages.

I added a navigation guard in the router file that redirects a user to the login page if a route has been marked as requiring authentication but the user is not logged in. After logging in, the user will be redirected to the page they originally tried to load. So far for the pages that have been pulled over, this is needed for the compose page.

Added archive token authentication for loading thumbnails/ archive data.

This branch is deployed on http://observation-portal-separate-frontend.lco.gtn/

Copy link
Contributor

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't take the closest look at the files that looked like they were just copied over, but the end result looks good.

src/archive.js Show resolved Hide resolved
src/components/Drafts.vue Outdated Show resolved Hide resolved
src/components/RequestgroupHeader.vue Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
@eheinrich eheinrich merged commit 41c05a3 into master Aug 27, 2020
@eheinrich eheinrich deleted the feature/add-requestgroups-pages branch August 27, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants