Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default display label for Typeahead component #676

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented Jun 10, 2019

The default Typeahead component emptyLabel is "no matches found." Sometimes the list lookup to LOC takes a couple of seconds, so changing the label to something more user friendly might help avoid confusion.

@jgreben jgreben marked this pull request as ready for review June 10, 2019 17:07
@jgreben
Copy link
Contributor Author

jgreben commented Jun 10, 2019

Per @justinlittman improve by making list retrieve when modal opens instead of onFocus

@peetucket peetucket merged commit fceca91 into master Jun 10, 2019
@peetucket peetucket deleted the language-select branch June 10, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants