New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples are not included in the pypi package #42

Closed
sanjayankur31 opened this Issue Oct 27, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@sanjayankur31
Contributor

sanjayankur31 commented Oct 27, 2018

The documentation mentions the examples, but these aren't included in the pypi install. Please include them.

@pgleeson

This comment has been minimized.

Member

pgleeson commented Oct 31, 2018

These are mentioned in the https://github.com/LEMS/pylems/blob/master/MANIFEST.in file... Is there something else in setup.py that needs to be added to propagate these additions?

@mstimberg

This comment has been minimized.

mstimberg commented Oct 31, 2018

The MANIFEST.in file uses include examples *.xml, this should be include examples/*.xml (or simply include examples/* given that there are also .py files.

sanjayankur31 added a commit to sanjayankur31/pylems that referenced this issue Nov 7, 2018

@pgleeson pgleeson closed this in #43 Nov 7, 2018

@pgleeson

This comment has been minimized.

Member

pgleeson commented Nov 8, 2018

The examples, along with the licence file, are now included in the release file at https://pypi.org/project/PyLEMS/0.4.9.3/#files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment