LExpress/doctrine1 and Doctrine.php #108

Closed
coldlamper opened this Issue Nov 12, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@coldlamper

Why is the file /lib/Doctrine.php left out.
It leaves out

class Doctrine extends Doctrine_Core
{
}

which breaks some code like Doctrine::getTable.

@j0k3r

This comment has been minimized.

Show comment
Hide comment
@j0k3r

j0k3r Nov 12, 2015

Member

As the comment in the class says:

This class only exists for backwards compatability. All code was moved to Doctrine_Core and this class extends Doctrine_Core

This isn't something we made, it had been done in the main doctrine1 repo (as far as I remember it was changed when the 1.2.0 goes out).

https://github.com/doctrine/doctrine1/blob/master/lib/Doctrine.php

You need to update all your code where you are using Doctrine: to Doctrine_Core::

Member

j0k3r commented Nov 12, 2015

As the comment in the class says:

This class only exists for backwards compatability. All code was moved to Doctrine_Core and this class extends Doctrine_Core

This isn't something we made, it had been done in the main doctrine1 repo (as far as I remember it was changed when the 1.2.0 goes out).

https://github.com/doctrine/doctrine1/blob/master/lib/Doctrine.php

You need to update all your code where you are using Doctrine: to Doctrine_Core::

@j0k3r j0k3r closed this Nov 12, 2015

@coldlamper

This comment has been minimized.

Show comment
Hide comment
@coldlamper

coldlamper Nov 12, 2015

Ahh. Thanks. There are some plugins like sfGuardDoctrinePlugin which I would rather not edit. I think it will be easier to just add

class Doctrine extends Doctrine_Core
{
}

Ahh. Thanks. There are some plugins like sfGuardDoctrinePlugin which I would rather not edit. I think it will be easier to just add

class Doctrine extends Doctrine_Core
{
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment