Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not claim copyright for future years yet #1

Closed
wants to merge 1 commit into from

Conversation

bmwiedemann
Copy link

Do not claim copyright for future years yet.

While working on reproducible builds for openSUSE, I found that
without this patch, building python-linstor-1.1.2
later would produce different build results:

+++ new//usr/lib/python3.8/site-packages/linstor/properties.py  2020-06-01 00:00
:00.000000000 +0000
@@ -2,7 +2,7 @@
 This file was autogenerated by genproperties.py

 LINSTOR - management of distributed storage/DRBD9 resources
-Copyright (C) 2017 - 2020  LINBIT HA-Solutions GmbH
+Copyright (C) 2017 - 2035  LINBIT HA-Solutions GmbH
 Author: Rene Peinthor, Gabor Hernadi

See also on this topic:
https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated

While working on reproducible builds for openSUSE, I found that
without this patch, building python-linstor-1.1.2
later would produce different build results:

+++ new//usr/lib/python3.8/site-packages/linstor/properties.py  2020-06-01 00:00
:00.000000000 +0000
@@ -2,7 +2,7 @@
 This file was autogenerated by genproperties.py

 LINSTOR - management of distributed storage/DRBD9 resources
-Copyright (C) 2017 - 2020  LINBIT HA-Solutions GmbH
+Copyright (C) 2017 - 2035  LINBIT HA-Solutions GmbH
 Author: Rene Peinthor, Gabor Hernadi

See also on this topic:
https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated
@bmwiedemann
Copy link
Author

Other possible ways to solve this :

  • use mtime of a relevant input file
  • use SOURCE_DATE_EPOCH
  • Have a script in git to autoupdate dates in a commit

@rp-
Copy link
Contributor

rp- commented Aug 3, 2020

thanks, we'll use the mtime approach

@rp- rp- closed this Aug 3, 2020
@bmwiedemann
Copy link
Author

Found commit 6ff3445 and it works fine.

@bmwiedemann bmwiedemann deleted the copyright branch August 9, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants