Skip to content

LIT-3897 - Implement pruning of expired capacity token NFTs #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2025
Merged

LIT-3897 - Implement pruning of expired capacity token NFTs #15

merged 4 commits into from
Jun 12, 2025

Conversation

@MaximusHaximus
Copy link
Contributor

@MaximusHaximus MaximusHaximus commented Sep 24, 2024 •
edited
Loading

  • Adds a call to pruneExpired() function that will be called after minting a new NFT to a target address
  • This will keep performance from being degraded if our target accounts don't ever clean up existing, expired RLI NFTs manually on their end.
  • Also updated infrastructure (engines, packageManager) to match reality (heroku is running on > Node20 now)

Ansonhkg
Ansonhkg requested changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to use the latest helper function

@MaximusHaximus MaximusHaximus force-pushed the LIT-3897-pruneExpired branch from 60d374a to 5b60d1a Compare June 12, 2025 01:38
@MaximusHaximus
feat(lit-task-auto-top-up): LIT-3897 - Finish pruning implementation
8655876 
- Make pruning happen for every recipient, even if they have unexpired tokens
- Make pruning an optional operation (no error thrown if it fails, just log the error)
- Add logging of pruning operations for visibility that the process is working as expected
- Update package manager dependency, node engines, and tsconfig references to match heroku reality -- and nvmrc too
- Remove support for sunsetted networks (cayenne, habanero, manzano)
- Update type check/parsing in `validateJSONRecipients.ts`
@MaximusHaximus MaximusHaximus merged commit 252fcbf into main Jun 12, 2025
1 of 2 checks passed
@MaximusHaximus MaximusHaximus deleted the LIT-3897-pruneExpired branch June 12, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ansonhkg Ansonhkg Ansonhkg requested changes

@glitch003 glitch003 glitch003 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MaximusHaximus @glitch003 @Ansonhkg