New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number fields should not accept non-number characters(ex. Japanese) #1857

Open
champierre opened this Issue Jan 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@champierre
Copy link

champierre commented Jan 7, 2019

Expected Behavior

Number fields should not accept non-number characters like Japanese.
Changing the background color of number fields to red is good UI(see how "point in direction" block behaves in the gif animation) because the user will notice that he/she made mistype.

Actual Behavior

Number fields of any block except "point in direction" accept non-number characters like Japanese.

scratch3

This is especially bad if user input full-width number(https://en.wikipedia.org/wiki/Halfwidth_and_fullwidth_forms) because it is hard to notice the error.

2019-01-07 17 21 20

Ref.
Scratch 2 behaves correctly. Number fields do not accept Japanese.

scratch2

Steps to Reproduce

  • Place any block that has number input field like "move steps" or "turn degrees".
  • Input Japanese characters in the input field.

Operating System and Browser

Mac OS 10.14.2 Chrome 71.0.3578.98

@thisandagain

This comment has been minimized.

Copy link
Member

thisandagain commented Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment