Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/merge feb 2017 #791
It looks like travis is unhappy due to eslint issues with the tests:
I think we could just make exceptions here to the
"In the horizontal blocks:
"Extremely minor, but I noticed that we now have a stroke around the insertion shadow."
RE: no-undef: were those rules ever being applied to the unit tests, or is it just that the new unit tests aren't set up to be exceptions and the old ones were?
Insertion shadow: Fixed, I think. Looks like that wasn't quite right before, but two bugs combined to become a feature, and I fixed one of those bugs in this PR.
I think I'm all set. If you're happy with this, please squash and merge it in. Then I can write some extension demos for you.
When testing in the VM playground, we get a fatal exception on the line:
var flyoutWorkspace = workspace.getFlyout().getWorkspace();
Uncaught TypeError: workspace.getFlyout is not a function at window.onload (playground.js:64)
Did the API for this change? @rschamp can you please review this as well?
Not quite--we failed at the merge last time and ended up with two versions of getFlyout_ in workspace_svg:
I removed one to dedupe it.
I can fix this for y'all by making workspace:getFlyout and workspace_svg:getFlyout public, though that's out of sync with mainline blockly. Is that the fix you want?