Set procedure param missing #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgoddard
force-pushed
the
set-procedure-param-missing
branch
from
d9a9e13 to
cfccfaa
Compare
mzgoddard
force-pushed
the
set-procedure-param-missing
branch
from
cfccfaa to
406db25
Compare
mzgoddard
force-pushed
the
set-procedure-param-missing
branch
from
406db25 to
fcafcbd
Compare
kchadha
reviewed
Oct 23, 2018
| if (frame.params.hasOwnProperty(paramName)) { | ||
| return frame.params[paramName]; | ||
| } | ||
| return null; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kchadha
reviewed
Oct 23, 2018
Contributor
|
@mzgoddard, I think this PR is good to go since you answered my question offline. I copied your answer in response to my comment in the code changes. I'm going to merge this in so that it can get smoke tested this Friday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Parameters outside of their procedure definition always return 0.
Proposed Changes
Depends on #1642
Reason for Changes
Scratch 2 behaviour for parameters outside their procedure (or when the procedure is stack clicked) always returns 0.
Test Coverage
Added 6 integration tests to test parameters outside their procedure under a green flag event and under a different procedure.