Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle view count for new project page #1858

Closed
chrisgarrity opened this issue Apr 18, 2018 · 4 comments

Comments

Projects
None yet
7 participants
@chrisgarrity
Copy link
Member

commented Apr 18, 2018

Use green flag prop from LLK/scratch-gui#3968 to call end point in LLK/scratch-api#476

@chrisgarrity chrisgarrity added this to the April 2018 milestone Apr 18, 2018

@chrisgarrity chrisgarrity self-assigned this Apr 18, 2018

@towerofnix

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2018

If the new count is not over 100, call the API endpoint to increment view count

Just to clarify, what does this imply? It sounds like it means that, under the new project page, projects would be limited to having 100 views, but I don't understand why that'd be intended.

@chrisgarrity chrisgarrity added the blocked label May 2, 2018

@chrisgarrity chrisgarrity modified the milestones: April 2018, May 2018 May 2, 2018

@chrisgarrity chrisgarrity modified the milestones: May 2018, June 2018 Jun 1, 2018

@chrisgarrity chrisgarrity removed this from the June 2018 milestone Jul 9, 2018

@chrisgarrity chrisgarrity removed their assignment Jul 9, 2018

@thisandagain thisandagain added this to the August 2018 milestone Jul 9, 2018

@joker314

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2018

As a slightly secondary question, will there be checks made server-side to enforce the 100-view limit, or just client side?

@colbygk

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

Hi @joker314 and @towerofnix A guiding principle of Scratch is to encourage constructive learning and positive community interactions. Gaming views is a part of the system we have to spend considerable resources on avoiding (in both database transactions and informational storage), and yet, even if we had a perfectly non-game-able system, it makes for a competitive metric that we'd like to avoid leading to negative experiences within the wider community.

@benjiwheeler

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2018

Closed by the combination of four PRs, referenced above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.