Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh-1930: Teacher registration dates #2098

Merged
merged 1 commit into from Sep 28, 2018

Conversation

@chen-robert
Copy link
Contributor

commented Sep 21, 2018

Resolves #1930

Changes:

Previously, the validation made it so the year Input was invalid. Even though changing the month puts the birth date over 16 years, the form still thinks that the year input is invalid. By changing it to an inline validation we resolve this problem because the check gets called everytime an input is changed.

@rschamp
Copy link
Member

left a comment

This looks like the right way to handle this, thanks for taking care of it @chen-robert!

@rschamp rschamp merged commit 5278e77 into LLK:develop Sep 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BryceLTaylor BryceLTaylor added QA-OK and removed needs-qa labels Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.