Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix gh-2160: Search with % #2161
Because query terms only sometimes need to be decoded, we attempt URI decoding and silence the error if it fails. This lets us still search with queries like
FYI, one piece of our workflow (I just joined the team recently, this is new to me and was not obvious) is that we use github's "assignee" and "labels" info to tell each other "I updated, can you take a look" or "this needs revision". So after you updated, you could assign me, take off the "needs work" label, and put on the "needs review" label.
So I tested this out. It's a big improvement for some searches, like your example of "100%pen" (or even "100% pen" -- both crash the page right now, but not with your improvement).
I'm not sure we should stop parsing the
Before approving, however, I just want to run this by @thisandagain .