Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh-2263: Negative loves #2314

Merged
merged 1 commit into from Nov 29, 2018

Conversation

@chen-robert
Copy link
Contributor

commented Nov 15, 2018

Resolves #2263 on Client Side

Implemented simple sanity checks to ensure that loveCount and favoriteCount can never display as negative. We may still need to resolve this issue server side.

@chen-robert chen-robert changed the title Resolved issue #2263 Fix https://github.com/LLK/scratch-www/issues/2263: Negative loves Nov 15, 2018

@chen-robert chen-robert changed the title Fix https://github.com/LLK/scratch-www/issues/2263: Negative loves Fix gh-2263: Negative loves Nov 15, 2018

@thisandagain thisandagain added this to the November 2018 milestone Nov 26, 2018

@thisandagain thisandagain requested a review from benjiwheeler Nov 28, 2018

@benjiwheeler
Copy link
Contributor

left a comment

Tested this out, it looks good!

Thanks for the fix, @chen-robert !

@benjiwheeler benjiwheeler merged commit 84dc08b into LLK:develop Nov 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.