Update ScratchX with changes that increase compatibility with Safari #103

Closed
kaschm opened this Issue Jan 3, 2017 · 0 comments

Projects

None yet

2 participants

@kaschm
kaschm commented Jan 3, 2017 edited

I believe the relevant issue in the Scratch codebase is:
LLK/scratchr2#4112

@mewtaylor for confirmation?

@kaschm kaschm added the prio-high label Jan 3, 2017
@kaschm kaschm added this to the January 19 milestone Jan 3, 2017
@cwillisf cwillisf was assigned by kaschm Jan 3, 2017
@kaschm kaschm modified the milestone: January 19, January 17 Release Jan 3, 2017
@cwillisf cwillisf added a commit to cwillisf/scratchx that referenced this issue Jan 4, 2017
@cwillisf cwillisf Fix GH-103: Create SWF regardless of platform
Port LLK/scratchr2#4168 for ScratchX.

Original description from that change:
> This fixes #4112 by creating the swf regardless of OS and browser.
> Calling `embedSWF` would first check for the existence of the plugin
> before creating, causing browsers that don’t allow the flash plugin by
> default to not be able to show their “allow” message. This tries to
> create the swf no matter what, allowing browsers to detect flash
> themselves.
>
> Logic is as follows:
> 1. check if `userAgent` returns a mobile/tablet OS. Display error
>    message if so
> 2. check if on windows and using ie – check for an express install if
>    so (like in `embedSWF`)
> 3. load the swf in all other cases, let browsers handle it.
>
> Test Cases:
> - Test how project pages load in Android and iOS devices, on tablets
>   and on phones, and on multiple desktop OS's for correct loading
>   behavior.

This resolves LLK/scratchx#103
e2455a0
@cwillisf cwillisf closed this in #107 Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment