Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix burstfs and cruise license #15

Merged
merged 1 commit into from Dec 8, 2017
Merged

fix burstfs and cruise license #15

merged 1 commit into from Dec 8, 2017

Conversation

dsikich
Copy link
Contributor

@dsikich dsikich commented Dec 8, 2017

Updated license text to say burstfs or cruise instead of unifycr. When the
function and variable names were updated to say unifycr instead of burstfs, the
license text for the burstfs text also got changed to unifycr. These updates
correct the license text to use the burstfs copyright. Also, the cruise
copyright was also updated similarly because it had the same issue. All full
license text was added at the top level of the repository.

Motivation and Context

When changing source code prefixes and functions to unifycr prefix instead of burstfs or cruise the license text in the source files mistakenly got changed as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • [ x] Documentation (a change to man pages or other documentation)

Checklist:

  • [ x] My code follows the UnifyCR code style requirements.
  • [ x] I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • [x ] All commit messages are properly formatted.

@nedbass
Copy link
Member

nedbass commented Dec 8, 2017

Thanks for working through all the complications with the style checker @dsikich! I think we should disregard the make checkstyle failure for the PR because it's mainly related to DOS-style CRLF line terminators that are pervasive throughout the code base. I will submit a separate PR to clean up those files.

LICENSE.CRUISE Outdated
to deal in the Software without restriction, including without limitation the rights to use,
copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and
to permit persons to whom the Software is furnished to do so, subject to the following
This file is part of UnifyCR For details, see https://github.com/llnl/unifycr.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is LICENSE.CRUISE, should it say "this file is part of CRUISE"?

Updated license text to say burstfs or cruise instead of unifycr. When the
function and variable names were updated to say unifycr instead of burstfs, the
license text for the burstfs text also got changed to unifycr. These updates
correct the license text to use the burstfs copyright. Also, the cruise
copyright was also updated similarly because it had the same issue. All full
license text was added at the top level of the repository.
@dsikich
Copy link
Contributor Author

dsikich commented Dec 8, 2017

@kathrynmohror @adammoody @nedbass Thanks, fixed LICENSE.CRUISE. This is ready to merge.

@adammoody adammoody merged commit f937dd5 into LLNL:dev Dec 8, 2017
MichaelBrim added a commit to MichaelBrim/UnifyFS that referenced this pull request Dec 4, 2018
# This is the 1st commit message:

# This is a combination of 14 commits.
# This is the 1st commit message:

initial behavior debug

# This is the commit message #2:

fix int/long/size_t/off_t confusion

# This is the commit message LLNL#3:

more size_t fixes

# This is the commit message LLNL#4:

code rationalization

# This is the commit message LLNL#5:

debug logging

# This is the commit message LLNL#6:

more debugging

# This is the commit message LLNL#7:

more understanding

# This is the commit message LLNL#8:

more reasonable constant values

# This is the commit message LLNL#9:

zero buffers before use

# This is the commit message LLNL#10:

more cleanup and callocs

# This is the commit message LLNL#11:

append uid to runstate file

# This is the commit message LLNL#12:

create runstate file after MPI_Init

# This is the commit message LLNL#13:

simplify client context copy

# This is the commit message LLNL#14:

debug meta_batch_get

# This is the commit message #2:

sysio-writeread example improvements

# This is the commit message LLNL#3:

tons more understanding and size_t cleanup

# This is the commit message LLNL#4:

build fixes

# This is the commit message LLNL#5:

build fixes

# This is the commit message LLNL#6:

build fixes

# This is the commit message LLNL#7:

build fixes

# This is the commit message LLNL#8:

build fixes

# This is the commit message LLNL#9:

build fixes

# This is the commit message LLNL#10:

simplify lio_listio aiocb_list setup

# This is the commit message LLNL#11:

clean up mdhim range_server_bget leveldb code

# This is the commit message LLNL#12:

add server include path

# This is the commit message LLNL#13:

add common include path

# This is the commit message LLNL#14:

remove old macros

# This is the commit message LLNL#15:

build fixes

# This is the commit message LLNL#16:

fix value computed not used warning

# This is the commit message LLNL#17:

fix printf formats

# This is the commit message LLNL#18:

build fixes

# This is the commit message LLNL#19:

fix UNIFYCR_VAL_SZ definition

# This is the commit message LLNL#20:

fix mismatch between client and server read request structs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants