Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiler spec for macos mojave to our uberenv setup #46

Closed
kennyweiss opened this issue May 23, 2019 · 6 comments · Fixed by #48
Closed

Add compiler spec for macos mojave to our uberenv setup #46

kennyweiss opened this issue May 23, 2019 · 6 comments · Fixed by #48
Labels
Build system Issues related to Axom's build system TPL Issues related to Axom's third party libraries

Comments

@kennyweiss
Copy link
Member

A user was unable to run uberenv on their macos laptop.

It looks like we will need to add a spec for mojave here:
https://github.com/LLNL/axom/blob/develop/scripts/uberenv/spack_configs/darwin/compilers.yaml

@kennyweiss kennyweiss added TPL Issues related to Axom's third party libraries Build system Issues related to Axom's build system labels May 23, 2019
@gzagaris
Copy link
Member

I'd advise they create their own compilers.yaml for their system and supply that when invoking uberenv by passing --compiler-yaml path/to/compilers.yaml and a corresponding --spec %<myspec>

That way we don't have to make any assumptions about what compilers are available on a given system and where they are.

@kennyweiss
Copy link
Member Author

Thanks @gzagaris.

I don't see that option here: https://github.com/LLNL/axom/blob/develop/scripts/uberenv/uberenv.py

Maybe it changed to "--spack-config-dir"

# this option allows a user to explicitly to select a
# group of spack settings files (compilers.yaml , packages.yaml)
parser.add_option("--spack-config-dir",
dest="spack_config_dir",
default=None,
help="dir with spack settings files (compilers.yaml, packages.yaml, etc)")

@gzagaris
Copy link
Member

gzagaris commented May 23, 2019

Yes, you are correct, it changed recently to --spack-config-dir.

You give it the the path to the directory where you have your own compiler.yaml.

For example, I build TPLs on my mac like this:

#!/bin/bash
mydir=`pwd`
python source/axom/scripts/uberenv/uberenv.py --prefix TPL -k --spec %clang@mp4.0^conduit@master --spack-config-dir $mydir``

@cyrush
Copy link
Member

cyrush commented May 23, 2019

I think it's still handy to have the standard xcode compilers in our spack config.

Spack used to be less picky, but now needs entire per os.
This is how we are currently supporting 10.12 and 10.13, there is no reason not to for 10.14.

The paths are the same, we just need to copy and update the compiler version and the os version in:

https://github.com/LLNL/axom/blob/develop/scripts/uberenv/spack_configs/darwin/compilers.yaml

@gzagaris
Copy link
Member

@cyrush, agreed -- doesn't hurt to have the standard xcode compilers.

@kennyweiss
Copy link
Member Author

Thanks @cyrush and @gzagaris -- we were able to figure it out by running spack compiler find

Spack wanted the compiler spec to be clang@10.0.0-apple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build system Issues related to Axom's build system TPL Issues related to Axom's third party libraries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants