Feature/capps2/sidre group save #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltaylor16
approved these changes
Sep 19, 2019
nselliott
approved these changes
Sep 19, 2019
agcapps
commented
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sidre::GroupGroup::isEquivalentTo()to optionally ignore the name of the group (issue Group::isEquivalentTo() should be able to ignore the group name #103 )Group::save()to not prune empty Groups (issue Group::save() should not prune empty Groups #102)Design review
On Sep 16 2019, the Axom group discussed several related issues with the Group class, saving, and loading. The issues this PR addresses were covered in that discussion.